6M3- [Scripting]Completing existing function codes

[Amethyst]

  Quote

Before we move on to getting the new content into the game, it's probably best we patch-up the existing things. It'll be much easier to say "6th gen content is incomplete" than to say "Uhhh yeah some stuff from 6th gen works but some stuff from 4th/5th gen doesn't......."

SO

Let's be clear on exactly everything that needs doing, and as help becomes available, we can hopefully knock some of these things off the list.

But this time with the function codes behind move effects, yayyyyy!

  Reveal hidden contents

• 003: Sleep Powder and Spore (among other moves in the same function code. Only these two moves should no longer effect Overcoat and Goggles Pokemon.)
• 005: Poison Powder (among other moves in the same function code. Only this move should no longer effect Overcoat and Goggles Pokemon.)
• 007: Stun Spore (among other moves in the same function code. Only this move should no longer effect Overcoat and Goggles Pokemon.)
• 03D: V-Create (The user's ally loses 1/16 of its total HP (this is not considered an attack by the user on that ally). "Ally currently doesn't lose HP." -- See Flame Burst on 074
• 04D: Cotton Spore (also Scary Face on the same function code Only this move should no longer effect Overcoat and Goggles Pokemon.)
• 05F: Conversion2 ("Currently the move's type is its original type rather than its determined type, e.g. for Hidden Power. Should the move's type be affected by Normalize?")
• 060: Camouflage ("Needs a snow/ice terrain tag to latch onto- easy enough to create the new tag but we need to set a handler for its effect
• 069: Transform ("If the transformed user's sprite somehow changes later on, the species/gender/shininess will be inconsistent - is this possible?" With the addition of Aegislash, it is. Do other cases exist?) ((also am i the only one amused by the fact that of all things to be on function code 69 it's Ditto's signature move?))
• 074: Flame Burst - Unimplemented ("The target's ally loses 1/16 of its total HP. This is not considered an attack by the user on that ally.") Woowbowiz coded an addition to this that didn't make it in before, we just need to fetch that
• 079: Fusion Bolt- Unimplemented
• 07A: Fusion Flare- Unimplemented
• 083: Round- Unimplemented
• 084: Payback- Unimplemented
• 075: Retaliate- Unimplemented
• 088: Pursuit ("Currently doesn't apply to fleeing targets.")
• 09C: Helping Hand ("Currently doesn't fail if the partner has already moved this turn.")
• 0A4: Secret Power ("There currently isn't a defined snow/ice environment, so this move can't have that effect.") This may not require a change but it should be looked at.
• 0AA: Protect/Detect ("Currently doesn't fail if used last in the round.")
• 0AB: Quick Guard - Unimplemented
• 0AC: Wide Guard- Unimplemented
• 0AD: Feint- When the above two are done, must be changed to work for them. Also, King's Shield and Spiky Shield
• 0AF: Copycat- Unimplemented
• 0B0: Me First- Unimplemented
• 0B1: Magic Coat- ("When the "C" flag move is being used, what does Pressure do, and whose Pressure does it?")
• 0B2: Snatch- ("Currently doesn't fail if used last in the round. When the "D" flag move is being used, what does Pressure do, and whose Pressure does it?")
• 0B3: Nature Power- Needs to be hooked up to ice terrain tag- again no change may be necessary but needs to be checked
• 0C1: Beat Up- ("Beat Up will trigger certain abilities, such as Weak Armor and Justified, multiple times. It will not trigger Rocky Helmet or other recoil abilities on the party Pokemon." Ensure that this is accurate to the code")
• 0CE: Sky Drop- Unimplemented
• 0CF: Fire Spin/Bind/Clamp/Wrap/Sand Tomb/Magma Storm (Should no longer trap Ghost types)
• 0E1: Final Gambit- Unimplemented
• 0E8: Endure ("Should fail if used last in the round.")
• 0EE: U-Turn/Volt Switch ("Pursuit currently doesn't interrupt this move.")
• 0EF: Mean Look/Block/Spider Web (Should no longer effect Ghost types)
• 0F4: Pluck/Bug Bite ("The consumed berry effects are currently not in.")
• 0F7: Fling ("Flung berries do not currently give their effects.")
• 0F8: Embargo ("Embargo currently does not prevent the trainer from using items on affected Pokémon.")
• 106: Grass Pledge- Unimplemented
• 107: Fire Pledge- Unimplemented
• 108: Water Pledge- Unimplemented
• 111: Future Sight/Doom Desire ("Calculation should be done when damage is dealt, not when the move is used. It should take type into account. Other effects need to be done as well.")
• 117: Rage Powder (along with Follow Me in the same function code. Only Rage Powder should no longer effect Overcoat and Goggles Pokemon.)
• 118: Gravity ("Not sure if this works properly regarding being in the middle of moves that can no longer be used.") Test
• 11C: Smack Down ("Not sure if this works properly regarding being in the middle of moves that can no longer be used.") Test
• 11D: After You- Unimplemented
• 11E: Quash- Unimplemented
• 120: Ally Switch- Unimplemented
• 121: Foul Play- Unimplemented
• 124: Wonder Room- Unimplemented
• 125: Last Resort- Unimplemented

Priorites from this list:

Pledge Moves, Foul Play, Sky Drop, Payback, Round, Retailliate, Final Gambit

If you're familiar with Ruby and want to take a shot at fixing some of these things, please PM me. I'll do what I can to get you set up with a copy of RMXP and our latest script version.

Non-scripters should try to help test uncertainties where possible.

All changes to the code, however, will need to be documented. So, when posting a fix for one of these things, please post it in this topic. I'll then merge it into my master copy of the scripts.

[Linux]

it would probably be a good idea to set up a Git or Github repo, everyone can contribute then...

[Amethyst]

There are a few different problems with that, but since I'm syncing all of the documented changes into my copy of the scripts anyone can still do so; they just have to request the files from me first